netdev - Re: [PATCH/RFC net] ravb: do not use zero-length alighment DMA request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c99997c5-5c3f-d966-1ce4-e81dc7bfb42d@cogentembedded.com>
Date:   Thu, 12 Jan 2017 19:14:52 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:     David Miller <davem@...emloft.net>, horms@...ge.net.au
Cc:     magnus.damm@...il.com, netdev@...r.kernel.org,
        linux-renesas-soc@...r.kernel.org
Subject: Re: [PATCH/RFC net] ravb: do not use zero-length alighment DMA
 request

On 01/12/2017 07:04 PM, David Miller wrote:

>> What I now see is that a few lines further up there is:
>>
>> 	 if (skb_put_padto(skb, ETH_ZLEN))
>> 		goto drop;
>>
>> 	where ETH_ZLEN is 60.
>>
>> So I don't think we need to worry about skb->len being less than 60 and
>> this patch can be simplified to:
>>
>> 	if (len == 0)
>> 		len = 4;
>
> I'd say this might deserve a comment...

    Sure. And the one better than the original "quick fix"... :-)

MBR, Sergei