netdev - Re: [PATCH/RFC net] ravb: do not use zero-length alighment DMA request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170112.110402.1123747824643306383.davem@davemloft.net>
Date:   Thu, 12 Jan 2017 11:04:02 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     horms@...ge.net.au
Cc:     sergei.shtylyov@...entembedded.com, magnus.damm@...il.com,
        netdev@...r.kernel.org, linux-renesas-soc@...r.kernel.org
Subject: Re: [PATCH/RFC net] ravb: do not use zero-length alighment DMA
 request

From: Simon Horman <horms@...ge.net.au>
Date: Thu, 12 Jan 2017 16:46:47 +0100

> What I now see is that a few lines further up there is:
> 
> 	 if (skb_put_padto(skb, ETH_ZLEN))
> 		goto drop;
> 
> 	where ETH_ZLEN is 60.
> 
> So I don't think we need to worry about skb->len being less than 60 and
> this patch can be simplified to:
> 
> 	if (len == 0)
> 		len = 4;

I'd say this might deserve a comment...