netdev - Re: [PATCH] [v2] net: qcom/emac: grab a reference to the phydev on ACPI systems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170112.151423.1152252804419911864.davem@davemloft.net>
Date:   Thu, 12 Jan 2017 15:14:23 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     timur@...eaurora.org
Cc:     netdev@...r.kernel.org, johan@...nel.org
Subject: Re: [PATCH] [v2] net: qcom/emac: grab a reference to the phydev on
 ACPI systems

From: Timur Tabi <timur@...eaurora.org>
Date: Wed, 11 Jan 2017 16:45:51 -0600

> Commit 6ffe1c4cd0a7 ("net: qcom/emac: fix of_node and phydev leaks")
> fixed the problem with reference leaks on phydev, but the fix is
> device-tree specific.  When the driver unloads, the reference is
> dropped only on DT systems.
> 
> Instead, it's cleaner if up grab an reference on ACPI systems.
> When the driver unloads, we can drop the reference without having
> to check whether we're on a DT system.
> 
> Signed-off-by: Timur Tabi <timur@...eaurora.org>

Applied.