netdev - Re: [PATCH] [v2] net: qcom/emac: grab a reference to the phydev on ACPI systems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170112090753.GD7420@localhost>
Date:   Thu, 12 Jan 2017 10:07:53 +0100
From:   Johan Hovold <johan@...nel.org>
To:     Timur Tabi <timur@...eaurora.org>
Cc:     David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
        johan@...nel.org
Subject: Re: [PATCH] [v2] net: qcom/emac: grab a reference to the phydev on
 ACPI systems

On Wed, Jan 11, 2017 at 04:45:51PM -0600, Timur Tabi wrote:
> Commit 6ffe1c4cd0a7 ("net: qcom/emac: fix of_node and phydev leaks")
> fixed the problem with reference leaks on phydev, but the fix is
> device-tree specific.  When the driver unloads, the reference is
> dropped only on DT systems.
> 
> Instead, it's cleaner if up grab an reference on ACPI systems.
> When the driver unloads, we can drop the reference without having
> to check whether we're on a DT system.
> 
> Signed-off-by: Timur Tabi <timur@...eaurora.org>

Reviewed-by: Johan Hovold <johan@...nel.org>