netdev - Re: [PATCH net-next] mii_bus: increase MII_BUS_ID

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170113163108.GN10203@lunn.ch>
Date:   Fri, 13 Jan 2017 17:31:08 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Volodymyr Bendiuga <volodymyr.bendiuga@...il.com>
Cc:     f.fainelli@...il.com, netdev@...r.kernel.org,
        volodymyr.bendiuga@...termo.se,
        Magnus Öberg <magnus.oberg@...termo.se>
Subject: Re: [PATCH net-next] mii_bus: increase MII_BUS_ID_SIZE to 61

On Fri, Jan 13, 2017 at 04:19:12PM +0100, Volodymyr Bendiuga wrote:
> From: Volodymyr Bendiuga <volodymyr.bendiuga@...termo.se>
> 
> Some bus names are pretty long and do not fit into 20 chars.
> 
> Signed-off-by: Volodymyr Bendiuga <volodymyr.bendiuga@...termo.se>
> Signed-off-by: Magnus Öberg <magnus.oberg@...termo.se>
> ---
>  include/linux/phy.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/phy.h b/include/linux/phy.h
> index feb8a98..b67f94d 100644
> --- a/include/linux/phy.h
> +++ b/include/linux/phy.h
> @@ -162,7 +162,7 @@ static inline const char *phy_modes(phy_interface_t interface)
>   * Need to be a little smaller than phydev->dev.bus_id to leave room
>   * for the ":%02x"
>   */
> -#define MII_BUS_ID_SIZE	(20 - 3)
> +#define MII_BUS_ID_SIZE	(64 - 3)

Hi Volodymyr

Humm, i assume you looked at the comment? What is the size of phydev->dev.bus_id?
Is 61 still a little smaller?

      Andrew