netdev - Commit 1fe8e0... (include more headers in if_tunnel.h) breaks my user-space build.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <f1cede01-3fa4-130a-fa2d-7cbdfe3648b3@candelatech.com>
Date:   Fri, 13 Jan 2017 11:12:32 -0800
From:   Ben Greear <greearb@...delatech.com>
To:     netdev <netdev@...r.kernel.org>, mikko.rapeli@....fi
Subject: Commit 1fe8e0... (include more headers in if_tunnel.h) breaks my
 user-space build.

I am including netinet/ip.h, and also linux/if_tunnel.h, and the linux/ip.h conflicts with
netinet/ip.h.

Maybe my build environment is screwed up, but maybe also it would be better to
just let the user include appropriate headers before including if_tunnel.h
and revert this patch?

include/uapi/linux/if_tunnel.h: include linux/if.h, linux/ip.h and linux/in6.h

     Fixes userspace compilation errors like:

     error: field ‘iph’ has incomplete type
     error: field ‘prefix’ has incomplete type

     Signed-off-by: Mikko Rapeli <mikko.rapeli@....fi>
     Signed-off-by: David S. Miller <davem@...emloft.net>

Thanks,
Ben

-- 
Ben Greear <greearb@...delatech.com>
Candela Technologies Inc  http://www.candelatech.com