netdev - Re: Commit 1fe8e0... (include more headers in if

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f9c15b13-5e76-129f-bcaa-27e5cc1f27b3@candelatech.com>
Date:   Fri, 13 Jan 2017 11:21:01 -0800
From:   Ben Greear <greearb@...delatech.com>
To:     netdev <netdev@...r.kernel.org>, mikko.rapeli@....fi
Subject: Re: Commit 1fe8e0... (include more headers in if_tunnel.h) breaks my
 user-space build.

On 01/13/2017 11:12 AM, Ben Greear wrote:
> I am including netinet/ip.h, and also linux/if_tunnel.h, and the linux/ip.h conflicts with
> netinet/ip.h.
>
> Maybe my build environment is screwed up, but maybe also it would be better to
> just let the user include appropriate headers before including if_tunnel.h
> and revert this patch?
>
>
> include/uapi/linux/if_tunnel.h: include linux/if.h, linux/ip.h and linux/in6.h
>
>     Fixes userspace compilation errors like:
>
>     error: field ‘iph’ has incomplete type
>     error: field ‘prefix’ has incomplete type
>
>     Signed-off-by: Mikko Rapeli <mikko.rapeli@....fi>
>     Signed-off-by: David S. Miller <davem@...emloft.net>
>
> Thanks,
> Ben
>

I forgot the full commit ID, my abbreviation was not sufficient to be unique it seems:

1fe8e0f074c77aa41aaa579345a9e675acbebfa9

Thanks,
Ben

-- 
Ben Greear <greearb@...delatech.com>
Candela Technologies Inc  http://www.candelatech.com