netdev - Re: [PATCH net-next v3 1/1] net sched actions: Add support for user cookies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170116072754.GA1804@nanopsycho.orion>
Date:   Mon, 16 Jan 2017 08:27:54 +0100
From:   Jiri Pirko <jiri@...nulli.us>
To:     Jamal Hadi Salim <jhs@...atatu.com>
Cc:     davem@...emloft.net, netdev@...r.kernel.org, jiri@...lanox.com,
        paulb@...lanox.com, john.fastabend@...il.com,
        simon.horman@...ronome.com, mrv@...atatu.com, hadarh@...lanox.com,
        ogerlitz@...lanox.com, roid@...lanox.com, xiyou.wangcong@...il.com,
        daniel@...earbox.net
Subject: Re: [PATCH net-next v3 1/1] net sched actions: Add support for user
 cookies

Sun, Jan 15, 2017 at 04:18:20PM CET, jhs@...atatu.com wrote:
>On 17-01-15 10:01 AM, Jiri Pirko wrote:
>> Sun, Jan 15, 2017 at 03:01:19PM CET, jhs@...atatu.com wrote:
>
>> > +cls_set_class(struct tcf_proto *tp, unsigned long *clp,
>> 
>> ??
>> 
>> > 	unsigned long cl)
>> > {
>> > 	unsigned long old_cl;
>> > -	
>> > +
>> 
>> ??
>> 
>> > 	tcf_tree_lock(tp);
>> > 	old_cl = __cls_set_class(clp, cl);
>> > 	tcf_tree_unlock(tp);
>> > -
>> > +
>> 
>> ??
>> 
>> > 	return old_cl;
>> > }
>> > 
>> > @@ -237,7 +237,7 @@ static inline int tcf_em_early_end(struct tcf_ematch *em, int result)
>> > 
>> > 	return 0;
>> > }
>> > -	
>> > +
>> 
>> ??
>> 
>
>All these things with "??" were annoying whitespace and stylistic
>things my fingers couldnt resist. It is legit to include such changes
>in a patch when touching the code (as long as not a bug fix).

Well, I think you should change this in a separate patch as it has 0
relation with this patch.