netdev - Re: [PATCH net] lwtunnel: fix autoload of lwt modules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170117.153846.1832359427601278475.davem@davemloft.net>
Date:   Tue, 17 Jan 2017 15:38:46 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     dsa@...ulusnetworks.com
Cc:     rshearma@...cade.com, netdev@...r.kernel.org,
        roopa@...ulusnetworks.com
Subject: Re: [PATCH net] lwtunnel: fix autoload of lwt modules

From: David Ahern <dsa@...ulusnetworks.com>
Date: Tue, 17 Jan 2017 11:04:35 -0700

> handling restart for all code paths seems a bit risky for
> 4.10. Perhaps then the best course for 4.10 and older stable
> releases is to remove the autoload code from lwtunnel. It can be
> re-added once the recovery path is handled.

Indeed, we would need to handle the restart rather far up in the call chain
above where the newroute message gets processed.

But, that being said, I don't think we can legitimately just remove the
autoload functionality.  It's been there for close to a full year and
I guarantee people will get burned if we take it away.

We have to find a way to fix this.