netdev - Re: [PATCHv2 7/7] IPVTAP: IP-VLAN based tap driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170118.162842.2116473511473193362.davem@davemloft.net>
Date:   Wed, 18 Jan 2017 16:28:42 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     sainath.grandhi@...el.com
Cc:     netdev@...r.kernel.org, mahesh@...dewar.net,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCHv2 7/7] IPVTAP: IP-VLAN based tap driver

From: Sainath Grandhi <sainath.grandhi@...el.com>
Date: Tue, 17 Jan 2017 16:03:06 -0800

> +static void ipvtap_count_tx_dropped(struct tap_dev *tap)
> +{
> +	struct ipvl_dev *vlan = (struct ipvl_dev *)container_of(tap, struct ipvtap_dev, tap);
 ...
> +static void ipvtap_count_rx_dropped(struct tap_dev *tap)
> +{
> +	struct ipvl_dev *vlan = (struct ipvl_dev *)container_of(tap, struct ipvtap_dev, tap);
 ...
> +static void ipvtap_update_features(struct tap_dev *tap,
> +				   netdev_features_t features)
> +{
> +	struct ipvl_dev *vlan = (struct ipvl_dev *)container_of(tap, struct ipvtap_dev, tap);

More unnecessary casts, please remove.