netdev - RE: [PATCHv2 7/7] IPVTAP: IP-VLAN based tap driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2C5142675EC1274EAB6230F72F8DC95F28C6D4C1@ORSMSX113.amr.corp.intel.com>
Date:   Thu, 19 Jan 2017 23:33:19 +0000
From:   "Grandhi, Sainath" <sainath.grandhi@...el.com>
To:     David Miller <davem@...emloft.net>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "mahesh@...dewar.net" <mahesh@...dewar.net>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCHv2 7/7] IPVTAP: IP-VLAN based tap driver



> -----Original Message-----
> From: David Miller [mailto:davem@...emloft.net]
> Sent: Wednesday, January 18, 2017 1:29 PM
> To: Grandhi, Sainath <sainath.grandhi@...el.com>
> Cc: netdev@...r.kernel.org; mahesh@...dewar.net; linux-
> kernel@...r.kernel.org
> Subject: Re: [PATCHv2 7/7] IPVTAP: IP-VLAN based tap driver
> 
> From: Sainath Grandhi <sainath.grandhi@...el.com>
> Date: Tue, 17 Jan 2017 16:03:06 -0800
> 
> > +static void ipvtap_count_tx_dropped(struct tap_dev *tap) {
> > +	struct ipvl_dev *vlan = (struct ipvl_dev *)container_of(tap, struct
> > +ipvtap_dev, tap);
>  ...
> > +static void ipvtap_count_rx_dropped(struct tap_dev *tap) {
> > +	struct ipvl_dev *vlan = (struct ipvl_dev *)container_of(tap, struct
> > +ipvtap_dev, tap);
>  ...
> > +static void ipvtap_update_features(struct tap_dev *tap,
> > +				   netdev_features_t features)
> > +{
> > +	struct ipvl_dev *vlan = (struct ipvl_dev *)container_of(tap, struct
> > +ipvtap_dev, tap);
> 
> More unnecessary casts, please remove.

Will take care of it in next revision. Thanks.