netdev - RE: [PATCHv2 3/7] TAP: Tap character device creation/destroy API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2C5142675EC1274EAB6230F72F8DC95F28C6D4CF@ORSMSX113.amr.corp.intel.com>
Date:   Thu, 19 Jan 2017 23:33:49 +0000
From:   "Grandhi, Sainath" <sainath.grandhi@...el.com>
To:     David Miller <davem@...emloft.net>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "mahesh@...dewar.net" <mahesh@...dewar.net>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCHv2 3/7] TAP: Tap character device creation/destroy API



> -----Original Message-----
> From: David Miller [mailto:davem@...emloft.net]
> Sent: Wednesday, January 18, 2017 1:27 PM
> To: Grandhi, Sainath <sainath.grandhi@...el.com>
> Cc: netdev@...r.kernel.org; mahesh@...dewar.net; linux-
> kernel@...r.kernel.org
> Subject: Re: [PATCHv2 3/7] TAP: Tap character device creation/destroy API
> 
> From: Sainath Grandhi <sainath.grandhi@...el.com>
> Date: Tue, 17 Jan 2017 16:03:02 -0800
> 
> > +int tap_create_cdev(struct cdev *tap_cdev,
> > +		    dev_t *tap_major, const char *device_name) {
> > +	int err;
> > +
> > +	err = alloc_chrdev_region(tap_major, 0, TAP_NUM_DEVS,
> device_name);
> > +
> > +	if (err)
> > +		goto out1;
> 
> No need to have an empty line between the alloc_chrdev_region() call and
> the "if (err)" test.
> 
> > diff --git a/include/linux/if_tap.h b/include/linux/if_tap.h index
> > d887aaa..a2dfd90 100644
> > --- a/include/linux/if_tap.h
> > +++ b/include/linux/if_tap.h
> > @@ -10,7 +10,7 @@ struct file;
> >  struct socket;
> >  static inline struct socket *tap_get_socket(struct file *f)  {
> > -        return ERR_PTR(-EINVAL);
> > +	return ERR_PTR(-EINVAL);
> >  }
> 
> Instead of having to fix up the indentation here, get it right in the first place in
> patch #2.

Will work on these two comments in next version.