netdev - Re: [PATCH net-next] fq_codel: Avoid regenerating skb flow hash unless necessary

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1484773993.16328.3.camel@edumazet-glaptop3.roam.corp.google.com>
Date:   Wed, 18 Jan 2017 13:13:13 -0800
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Andrew Collins <acollins@...dlepoint.com>
Cc:     netdev@...r.kernel.org, tom@...bertland.com
Subject: Re: [PATCH net-next] fq_codel: Avoid regenerating skb flow hash
 unless necessary

On Wed, 2017-01-18 at 14:04 -0700, Andrew Collins wrote:
> The fq_codel qdisc currently always regenerates the skb flow hash.
> This wastes some cycles and prevents flow seperation in cases where
> the traffic has been encrypted and can no longer be understood by the
> flow dissector.
> 
> Change it to use the prexisting flow hash if one exists, and only
> regenerate if necessary.
> 
> Signed-off-by: Andrew Collins <acollins@...dlepoint.com>
> ---

Acked-by: Eric Dumazet <edumazet@...gle.com>

Thanks !