netdev - Re: [PATCH net-next] fq_codel: Avoid regenerating skb flow hash unless necessary

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170120.121537.2279655261253689807.davem@davemloft.net>
Date:   Fri, 20 Jan 2017 12:15:37 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     acollins@...dlepoint.com
Cc:     netdev@...r.kernel.org, eric.dumazet@...il.com, tom@...bertland.com
Subject: Re: [PATCH net-next] fq_codel: Avoid regenerating skb flow hash
 unless necessary

From: Andrew Collins <acollins@...dlepoint.com>
Date: Wed, 18 Jan 2017 14:04:28 -0700

> The fq_codel qdisc currently always regenerates the skb flow hash.
> This wastes some cycles and prevents flow seperation in cases where
> the traffic has been encrypted and can no longer be understood by the
> flow dissector.
> 
> Change it to use the prexisting flow hash if one exists, and only
> regenerate if necessary.
> 
> Signed-off-by: Andrew Collins <acollins@...dlepoint.com>

Applied, thanks.