netdev - Re: [PATCH for bnxt_re V4 10/21] RDMA/bnxt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 18 Jan 2017 14:42:00 +0530
From:   Selvin Xavier <selvin.xavier@...adcom.com>
To:     Leon Romanovsky <leon@...nel.org>
Cc:     Doug Ledford <dledford@...hat.com>, linux-rdma@...r.kernel.org,
        Linux Netdev List <netdev@...r.kernel.org>,
        Michael Chan <michael.chan@...adcom.com>,
        Eddie Wai <eddie.wai@...adcom.com>,
        Devesh Sharma <devesh.sharma@...adcom.com>,
        Somnath Kotur <somnath.kotur@...adcom.com>,
        Sriharsha Basavapatna <sriharsha.basavapatna@...adcom.com>
Subject: Re: [PATCH for bnxt_re V4 10/21] RDMA/bnxt_re: Support for CQ verbs

On Wed, Jan 18, 2017 at 1:49 PM, Leon Romanovsky <leon@...nel.org> wrote:
> It is better to use already existing macros - min()
> cq->max_cql = min(entries, MAX_CQL_PER_POLL);
>
> I afraid that you can't avoid the respinning, you have more than month
> till merge window.
>
> Can you please remove useless wrappers and try to reuse kernel macros?

Leon,
  Thanks for your comments. I will include your both comments in the
next patch set.

Doug,
   Is it ok if I send out the V5 now after re-basing against for-4.11
branch or should i wait for your comments on V4?

Thanks,
Selvin