netdev - Re: [PATCH for bnxt_re V4 10/21] RDMA/bnxt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1484809053.2406.90.camel@redhat.com>
Date:   Thu, 19 Jan 2017 01:57:33 -0500
From:   Doug Ledford <dledford@...hat.com>
To:     Selvin Xavier <selvin.xavier@...adcom.com>,
        Leon Romanovsky <leon@...nel.org>
Cc:     linux-rdma@...r.kernel.org,
        Linux Netdev List <netdev@...r.kernel.org>,
        Michael Chan <michael.chan@...adcom.com>,
        Eddie Wai <eddie.wai@...adcom.com>,
        Devesh Sharma <devesh.sharma@...adcom.com>,
        Somnath Kotur <somnath.kotur@...adcom.com>,
        Sriharsha Basavapatna <sriharsha.basavapatna@...adcom.com>
Subject: Re: [PATCH for bnxt_re V4 10/21] RDMA/bnxt_re: Support for CQ verbs

On Wed, 2017-01-18 at 14:42 +0530, Selvin Xavier wrote:
> On Wed, Jan 18, 2017 at 1:49 PM, Leon Romanovsky <leon@...nel.org>
> wrote:
> > 
> > It is better to use already existing macros - min()
> > cq->max_cql = min(entries, MAX_CQL_PER_POLL);
> > 
> > I afraid that you can't avoid the respinning, you have more than
> > month
> > till merge window.
> > 
> > Can you please remove useless wrappers and try to reuse kernel
> > macros?
> 
> Leon,
>   Thanks for your comments. I will include your both comments in the
> next patch set.
> 
> Doug,
>    Is it ok if I send out the V5 now after re-basing against for-4.11
> branch or should i wait for your comments on V4?

Wait.

-- 
Doug Ledford <dledford@...hat.com>
    GPG KeyID: B826A3330E572FDD
   
Key fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)