netdev - Re: [PATCH] virtio: don't set VIRTIO_NET_HDR_F_DATA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ecc7cc21-9e46-9cee-e9bc-bb29dfd6b06a@cogentembedded.com>
Date:   Wed, 18 Jan 2017 15:07:11 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:     Rolf Neugebauer <rolf.neugebauer@...ker.com>,
        netdev@...r.kernel.org
Cc:     mst@...hat.com, davem@...emloft.net, jasowang@...hat.com,
        rppt@...ux.vnet.ibm.com
Subject: Re: [PATCH] virtio: don't set VIRTIO_NET_HDR_F_DATA_VALID on xmit

Hello!

On 1/17/2017 9:13 PM, Rolf Neugebauer wrote:

> This patch part reverts fd2a0437dc33 and e858fae2b0b8 which introduced a

    You also need to specify the patch summary lines enclosed in ("").

> subtle change in how the virtio_net flags are derived from the SKBs
> ip_summed field.
>
> With the above commits, the flags are set to VIRTIO_NET_HDR_F_DATA_VALID
> when ip_summed == CHECKSUM_UNNECESSARY, thus treating it differently to
> ip_summed == CHECKSUM_NONE, which should be the same.
>
> Further, the virtio spec 1.0 / CS04 explicitly says that
> VIRTIO_NET_HDR_F_DATA_VALID must not be set by the driver.
>
> Signed-off-by: Rolf Neugebauer <rolf.neugebauer@...ker.com>
[...]

MBR, Sergei