netdev - Re: [PATCH] net: add regs attribute to phy device for user diagnose

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 18 Jan 2017 13:37:06 +0100
From:   Zefir Kurtisi <zefir.kurtisi@...atec.com>
To:     YUAN Linyu <Linyu.Yuan@...atel-sbell.com.cn>,
        David Miller <davem@...emloft.net>,
        "f.fainelli@...il.com" <f.fainelli@...il.com>
Cc:     "cugyly@....com" <cugyly@....com>,
        "andrew@...n.ch" <andrew@...n.ch>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH] net: add regs attribute to phy device for user diagnose

On 01/17/2017 01:11 AM, YUAN Linyu wrote:
> 
> 
>> -----Original Message-----
>> From: David Miller [mailto:davem@...emloft.net]
>> Sent: Tuesday, January 17, 2017 5:54 AM
>> To: f.fainelli@...il.com
>> Cc: cugyly@....com; andrew@...n.ch; netdev@...r.kernel.org; YUAN Linyu
>> Subject: Re: [PATCH] net: add regs attribute to phy device for user diagnose
>>
>> From: Florian Fainelli <f.fainelli@...il.com>
>> Date: Mon, 16 Jan 2017 12:22:16 -0800
>>
>>>
>>> So why not add support in ethtool for reading PHY registers if you need
>>> it? There are handful of PHY "things" in ethtool, such as reading
>>> counters, configuring downshift etc., adding support for dumping
>>> registers does not sound out of space.
> Thanks, I will try this direction.
>>
>> Agreed.

... on the other hand, having direct RW access to MDIO regs can ease your life
greatly during bring-up / debugging of PHYs.

Attached is a patch we are using to track down PHY problems at register level, not
for integrating into the kernel but as a handy tool for developers.


Cheers,
Zefir



View attachment "0001-phy_device-add-sysfs-access-to-mdio-registers.patch" of type "text/x-patch" (3607 bytes)