netdev - RE: [PATCH] net: add regs attribute to phy device for user diagnose

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8729016553E3654398EA69218DA29EEF15A5A289@cnshjmbx04>
Date:   Thu, 19 Jan 2017 00:45:56 +0000
From:   YUAN Linyu <Linyu.Yuan@...atel-sbell.com.cn>
To:     Zefir Kurtisi <zefir.kurtisi@...atec.com>,
        David Miller <davem@...emloft.net>,
        "f.fainelli@...il.com" <f.fainelli@...il.com>
CC:     "cugyly@....com" <cugyly@....com>,
        "andrew@...n.ch" <andrew@...n.ch>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [PATCH] net: add regs attribute to phy device for user diagnose

> -----Original Message-----
> From: Zefir Kurtisi [mailto:zefir.kurtisi@...atec.com]
> 
> ... on the other hand, having direct RW access to MDIO regs can ease your life
> greatly during bring-up / debugging of PHYs.
> 
> Attached is a patch we are using to track down PHY problems at register level,
> not
> for integrating into the kernel but as a handy tool for developers.
> 

We should follow previous discussion and move this debug feature to ethtool.
Sysfs is not suggested by experts. I think it's reasonable and it's netdev development way.

One thing that your patch only care a few registers.
It's better to find a way to check all register of PHY.

I will add two ethtool command in kernel to read and write register in PHY. 
ethtool can use these command to dump what user want, there is no more work to PHY driver.

(
additional, mii-tool have two ioctl command[SIOCSMIIREG, SIOCGMIIREG], 
but is not export to use in mii-tool.
It's better to add command to eth-tool which maintained closely with kernel.
)

> 
> Cheers,
> Zefir
>