netdev - Re: [PATCH net] gianfar: Do not reuse pages from emergency reserve

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170119.115003.1254899603401185224.davem@davemloft.net>
Date:   Thu, 19 Jan 2017 11:50:03 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     eric.dumazet@...il.com
Cc:     netdev@...r.kernel.org, claudiu.manoil@...escale.com
Subject: Re: [PATCH net] gianfar: Do not reuse pages from emergency reserve

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Wed, 18 Jan 2017 19:44:42 -0800

> From: Eric Dumazet <edumazet@...gle.com>
> 
> A driver using dev_alloc_page() must not reuse a page that had to
> use emergency memory reserve.
> 
> Otherwise all packets using this page will be immediately dropped,
> unless for very specific sockets having SOCK_MEMALLOC bit set.
> 
> This issue might be hard to debug, because only a fraction of the RX
> ring buffer would suffer from drops.
> 
> Fixes: 75354148ce69 ("gianfar: Add paged allocation and Rx S/G")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Applied.