netdev - RE: [PATCH net] gianfar: Do not reuse pages from emergency reserve

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AM5PR0401MB256107232ECF3DFC8004657F967E0@AM5PR0401MB2561.eurprd04.prod.outlook.com>
Date:   Thu, 19 Jan 2017 14:04:19 +0000
From:   Claudiu Manoil <claudiu.manoil@....com>
To:     Eric Dumazet <eric.dumazet@...il.com>,
        David Miller <davem@...emloft.net>
CC:     netdev <netdev@...r.kernel.org>
Subject: RE: [PATCH net] gianfar: Do not reuse pages from emergency reserve

>-----Original Message-----
>From: Eric Dumazet [mailto:eric.dumazet@...il.com]
>Sent: Thursday, January 19, 2017 5:45 AM
>To: David Miller <davem@...emloft.net>
>Cc: netdev <netdev@...r.kernel.org>; Claudiu Manoil
><claudiu.manoil@...escale.com>
>Subject: [PATCH net] gianfar: Do not reuse pages from emergency reserve
>
>From: Eric Dumazet <edumazet@...gle.com>
>
>A driver using dev_alloc_page() must not reuse a page that had to
>use emergency memory reserve.
>
>Otherwise all packets using this page will be immediately dropped,
>unless for very specific sockets having SOCK_MEMALLOC bit set.
>
>This issue might be hard to debug, because only a fraction of the RX
>ring buffer would suffer from drops.
>
>Fixes: 75354148ce69 ("gianfar: Add paged allocation and Rx S/G")
>Signed-off-by: Eric Dumazet <edumazet@...gle.com>
>Cc: Claudiu Manoil <claudiu.manoil@...escale.com>

Thanks.

Acked-by: Claudiu Manoil <claudiu.manoil@....com>