netdev - Re: [patch net-next 2/4] net/sched: Introduce sample tc action

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52d57d84-6e0d-0ff3-5027-6dea06f4a683@mojatatu.com>
Date:   Sun, 22 Jan 2017 08:16:38 -0500
From:   Jamal Hadi Salim <jhs@...atatu.com>
To:     Jiri Pirko <jiri@...nulli.us>, netdev@...r.kernel.org
Cc:     davem@...emloft.net, yotamg@...lanox.com, idosch@...lanox.com,
        eladr@...lanox.com, nogahf@...lanox.com, ogerlitz@...lanox.com,
        geert+renesas@...der.be, stephen@...workplumber.org,
        xiyou.wangcong@...il.com, linux@...ck-us.net,
        roopa@...ulusnetworks.com, john.fastabend@...il.com,
        simon.horman@...ronome.com, mrv@...atatu.com
Subject: Re: [patch net-next 2/4] net/sched: Introduce sample tc action

On 17-01-22 06:44 AM, Jiri Pirko wrote:

> diff --git a/net/sched/act_sample.c b/net/sched/act_sample.c
> new file mode 100644
> index 0000000..24e20e4
> --- /dev/null
> +++ b/net/sched/act_sample.c
> @@ -0,0 +1,274 @@
> +/*
> + * net/sched/act_sample.c - Packet samplig tc action

typo: "Sampling"


> +static int tcf_sample(struct sk_buff *skb, const struct tc_action *a,
> +		      struct tcf_result *res)


Can you rename this function because it is also the name of the data
structure? It makes it easier to grep.
I know we have this all over the place in other actions (and i hope
those are cleaned up at some point).

otherwise:
Acked-by: Jamal Hadi Salim <jhs@...atatu.com>

cheers,
jamal