netdev - Re: [patch net-next 1/4] net: Introduce psample, a new genetlink channel for packet sampling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9f5b46ff-2bc1-7b28-e13a-625bc495496f@mojatatu.com>
Date:   Sun, 22 Jan 2017 08:19:35 -0500
From:   Jamal Hadi Salim <jhs@...atatu.com>
To:     Jiri Pirko <jiri@...nulli.us>, netdev@...r.kernel.org
Cc:     davem@...emloft.net, yotamg@...lanox.com, idosch@...lanox.com,
        eladr@...lanox.com, nogahf@...lanox.com, ogerlitz@...lanox.com,
        geert+renesas@...der.be, stephen@...workplumber.org,
        xiyou.wangcong@...il.com, linux@...ck-us.net,
        roopa@...ulusnetworks.com, john.fastabend@...il.com,
        simon.horman@...ronome.com, mrv@...atatu.com
Subject: Re: [patch net-next 1/4] net: Introduce psample, a new genetlink
 channel for packet sampling

On 17-01-22 06:44 AM, Jiri Pirko wrote:
> From: Yotam Gigi <yotamg@...lanox.com>
>
> Add a general way for kernel modules to sample packets, without being tied
> to any specific subsystem. This netlink channel can be used by tc,
> iptables, etc. and allow to standardize packet sampling in the kernel.
>
> For every sampled packet, the psample module adds the following metadata
> fields:
>
> PSAMPLE_ATTR_IIFINDEX - the packets input ifindex, if applicable
>
> PSAMPLE_ATTR_OIFINDEX - the packet output ifindex, if applicable
>
> PSAMPLE_ATTR_ORIGSIZE - the packet's original size, in case it has been
>    truncated during sampling
>
> PSAMPLE_ATTR_SAMPLE_GROUP - the packet's sample group, which is set by the
>    user who initiated the sampling. This field allows the user to
>    differentiate between several samplers working simultaneously and
>    filter packets relevant to him
>
> PSAMPLE_ATTR_GROUP_SEQ - sequence counter of last sent packet. The
>    sequence is kept for each group
>
> PSAMPLE_ATTR_SAMPLE_RATE - the sampling rate used for sampling the packets
>
> PSAMPLE_ATTR_DATA - the actual packet bits
>
> In addition, add the GET_GROUPS netlink command which allows the user to
> see the current sample groups, their refcount and sequence number. This
> command currently supports only netlink dump mode.
>
> Signed-off-by: Yotam Gigi <yotamg@...lanox.com>
> Signed-off-by: Jiri Pirko <jiri@...lanox.com>

Will be useful to describe in the commit log that one needs to listen
to PSAMPLE_NL_MCGRP_SAMPLE to see the samples.

Reviewed-by: Jamal Hadi Salim <jhs@...atatu.com>

cheers,
jamal