netdev - iproute2: using .maxattr = IFLA_VLAN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <58864115.4060608@ti.com>
Date:   Mon, 23 Jan 2017 12:44:53 -0500
From:   Murali Karicheri <m-karicheri2@...com>
To:     "open list:TI NETCP ETHERNET DRIVER" <netdev@...r.kernel.org>
Subject: iproute2: using .maxattr = IFLA_VLAN_MAX??

Hi iproute2 experts,

Found the below usage of IFLA_VLAN_MAX in ip/iplink_hsr.c

struct link_util hsr_link_util = {
        .id             = "hsr",
        .maxattr        = IFLA_VLAN_MAX, <==== should be IFLA_HSR_MAX
        .parse_opt      = hsr_parse_opt,
        .print_opt      = hsr_print_opt,
        .print_help     = hsr_print_help,
};

This appears to be a cut-n-paste bug as the source is based on 
ip/iplink_vlan.c and should be fixed to IFLA_HSR_MAX. If yes, 
I will send a patch for this.

Thanks.
-- 
Murali Karicheri
Linux Kernel, Keystone