netdev - RE: iproute2: using .maxattr = IFLA_VLAN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 23 Jan 2017 20:45:24 +0000
From:   "Rosen, Rami" <rami.rosen@...el.com>
To:     Murali Karicheri <m-karicheri2@...com>,
        "open list:TI NETCP ETHERNET DRIVER" <netdev@...r.kernel.org>
Subject: RE: iproute2: using .maxattr = IFLA_VLAN_MAX??

Hi, Murali,

> This appears to be a cut-n-paste bug as the source is based on ip/iplink_vlan.c and should be fixed to IFLA_HSR_MAX. 

You are right.
The "HSR section" indeed defines IFLA_HSR_MAX in include/linux/if_link.h of iproute2 as the max attributes number.

And in the top of ip/iplink_hsr.c you will find this comment, which enhances your assumption about the origin of this mistake:

/*
...
     Based on iplink_vlan.c by Patrick McHardy <kaber@...sh.net
...
 */

Regards,
Rami Rosen