netdev - Re: [PATCH net] net: reset ct before calling ndo_start

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170124.112137.997945919072068039.davem@davemloft.net>
Date:   Tue, 24 Jan 2017 11:21:37 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     pabeni@...hat.com
Cc:     netdev@...r.kernel.org, hannes@...essinduktion.org, fw@...len.de
Subject: Re: [PATCH net] net: reset ct before calling ndo_start_xmit

From: Paolo Abeni <pabeni@...hat.com>
Date: Tue, 24 Jan 2017 10:40:13 +0100

> Some devices (e.g. ipoib and most wifi drivers) can retain the
> to-be-xmitted packets on some internal queue for a possibly
> unlimited time.

This is really not legal, such behavior also potentially holds onto
sockets forever.

If driver really wants to hold onto an SKB potentially forever, it
must release these resources.

This belongs in the driver that violates, and I strongly say
"violates", the basic fundamental rules of TX handling in the stack.
Drivers absolutely must liberate queued TX packets in a reasonable,
finite, amount of time.