netdev - Re: [PATCH net] net: reset ct before calling ndo_start

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 24 Jan 2017 09:37:33 -0800
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Paolo Abeni <pabeni@...hat.com>
Cc:     netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
        Hannes Frederic Sowa <hannes@...essinduktion.org>,
        Florian Westphal <fw@...len.de>
Subject: Re: [PATCH net] net: reset ct before calling ndo_start_xmit

On Tue, 24 Jan 2017 10:40:13 +0100
Paolo Abeni <pabeni@...hat.com> wrote:

>  
> +/* return true if we should preserve skb nfct before calling ndo_start_xmit() */
> +static inline bool netif_needs_ct(struct net_device *dev)
> +{
> +	/* any kind of virtual device needs to preserve the ct entry */
> +	return dev->features & NETIF_F_LLTX;
> +}
> +

I am not sure I fully understand the problem, and this looks like a special case
hack. You are overloading meaning of LLTX flag in a new way.

If you must do it then code this in place, and put comment there.
The addition of accessor function just obscures the purpose.