netdev - Re: [PATCH net-next 00/18] netvsc driver enhancements for net-next

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170124.163005.1454633748162819090.davem@davemloft.net>
Date:   Tue, 24 Jan 2017 16:30:05 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     stephen@...workplumber.org
Cc:     kys@...rosoft.com, netdev@...r.kernel.org, sthemmin@...rosoft.com
Subject: Re: [PATCH net-next 00/18] netvsc driver enhancements for net-next

From: Stephen Hemminger <stephen@...workplumber.org>
Date: Tue, 24 Jan 2017 13:05:57 -0800

> Lots of little things in here. Support for minor more ethtool control,
> negotiation of offload parameters with host (based on FreeBSD) and
> several cleanups.

Series applied, but two comments for potential follow-on changes:

>   netvsc: enhance transmit select_queue

Wouldn't it be better to check for the channel table NULL pointer
before assigning the queue index to the socket?

>   netvsc: call netif_receive_skb

Hmmm, potential stack depth issues?