netdev - Re: [PATCH net-next 00/18] netvsc driver enhancements for net-next

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170124140055.4fac90de@xeon-e3>
Date:   Tue, 24 Jan 2017 14:00:55 -0800
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     David Miller <davem@...emloft.net>
Cc:     kys@...rosoft.com, netdev@...r.kernel.org, sthemmin@...rosoft.com
Subject: Re: [PATCH net-next 00/18] netvsc driver enhancements for net-next

On Tue, 24 Jan 2017 16:30:05 -0500 (EST)
David Miller <davem@...emloft.net> wrote:

> From: Stephen Hemminger <stephen@...workplumber.org>
> Date: Tue, 24 Jan 2017 13:05:57 -0800
> 
> > Lots of little things in here. Support for minor more ethtool control,
> > negotiation of offload parameters with host (based on FreeBSD) and
> > several cleanups.  
> 
> Series applied, but two comments for potential follow-on changes:
> 
> >   netvsc: enhance transmit select_queue  
> 
> Wouldn't it be better to check for the channel table NULL pointer
> before assigning the queue index to the socket?

Wanted to keep the original ordering out of paranoia.

> >   netvsc: call netif_receive_skb  
> 
> Hmmm, potential stack depth issues?

No more of an issue than net softirq before (ie process_backlog).
The call chain is:
  tasklet_action
	vmbus_on_event ... process_chn_event
		netvsc_channel_cb ... netif_receive_skb

NAPI/GRO support is possible but needs changes in VMBUS core code.