netdev - Re: [PATCH iproute2] tc: flower: Fix flower output for src and dst ports

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170124084217.GA30193@penelope.horms.nl>
Date:   Tue, 24 Jan 2017 09:42:19 +0100
From:   Simon Horman <simon.horman@...ronome.com>
To:     Roi Dayan <roid@...lanox.com>
Cc:     Stephen Hemminger <stephen@...workplumber.org>,
        netdev@...r.kernel.org, Paul Blakey <paulb@...lanox.com>
Subject: Re: [PATCH iproute2] tc: flower: Fix flower output for src and dst
 ports

On Sun, Jan 15, 2017 at 04:23:49PM +0200, Roi Dayan wrote:
> This fix a missing use case after the introduction of enum flower_endpoint.
> 
> Fixes: 6910d65661a3 ("tc: flower: introduce enum flower_endpoint")
> Signed-off-by: Roi Dayan <roid@...lanox.com>
> Signed-off-by: Paul Blakey <paulb@...lanox.com>

Thanks, sorry for missing that:

Reviewed-by: Simon Horman <simon.horman@...ronome.com>

> ---
>  tc/f_flower.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tc/f_flower.c b/tc/f_flower.c
> index 71e9515..1dbc532 100644
> --- a/tc/f_flower.c
> +++ b/tc/f_flower.c
> @@ -744,10 +744,10 @@ static int flower_print_opt(struct filter_util *qu, FILE *f,
>  			     tb[TCA_FLOWER_KEY_IPV6_SRC],
>  			     tb[TCA_FLOWER_KEY_IPV6_SRC_MASK]);
>  
> -	nl_type = flower_port_attr_type(ip_proto, false);
> +	nl_type = flower_port_attr_type(ip_proto, FLOWER_ENDPOINT_DST);
>  	if (nl_type >= 0)
>  		flower_print_port(f, "dst_port", tb[nl_type]);
> -	nl_type = flower_port_attr_type(ip_proto, true);
> +	nl_type = flower_port_attr_type(ip_proto, FLOWER_ENDPOINT_SRC);
>  	if (nl_type >= 0)
>  		flower_print_port(f, "src_port", tb[nl_type]);
>  
> -- 
> 1.7.1
>