netdev - Re: [PATCH net] tcp: correct memory barrier usage in tcp_check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1485320017.16328.386.camel@edumazet-glaptop3.roam.corp.google.com>
Date:   Tue, 24 Jan 2017 20:53:37 -0800
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Jason Baron <jbaron@...mai.com>
Cc:     davem@...emloft.net, netdev@...r.kernel.org,
        Oleg Nesterov <oleg@...hat.com>
Subject: Re: [PATCH net] tcp: correct memory barrier usage in
 tcp_check_space()

On Tue, 2017-01-24 at 21:49 -0500, Jason Baron wrote:
> From: Jason Baron <jbaron@...mai.com>
> 
> sock_reset_flag() maps to __clear_bit() not the atomic version clear_bit().
> Thus, we need smp_mb(), smp_mb__after_atomic() is not sufficient.
> 
> Fixes: 3c7151275c0c ("tcp: add memory barriers to write space paths")
> Cc: Eric Dumazet <eric.dumazet@...il.com>
> Cc: Oleg Nesterov <oleg@...hat.com>
> Signed-off-by: Jason Baron <jbaron@...mai.com>
> ---
>  net/ipv4/tcp_input.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Acked-by: Eric Dumazet <edumazet@...gle.com>

I believe this would need also this for proper attribution.

Reported-by: Oleg Nesterov <oleg@...hat.com>