netdev - Re: [PATCH net 1/4] r8152: avoid start_xmit to call napi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170124210251.202c383e@xeon-e3>
Date:   Tue, 24 Jan 2017 21:02:51 -0800
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Hayes Wang <hayeswang@...ltek.com>
Cc:     <netdev@...r.kernel.org>, <nic_swsd@...ltek.com>,
        <linux-kernel@...r.kernel.org>, <linux-usb@...r.kernel.org>
Subject: Re: [PATCH net 1/4] r8152: avoid start_xmit to call napi_schedule
 during autosuspend

On Wed, 25 Jan 2017 10:50:51 +0800
Hayes Wang <hayeswang@...ltek.com> wrote:

> Adjust the setting of the flag of SELECTIVE_SUSPEND to prevent start_xmit()
> from calling napi_schedule() directly during runtime suspend.
> 
> After calling napi_disable() or clearing the flag of WORK_ENABLE,
> scheduling the napi is useless.
> 
> Signed-off-by: Hayes Wang <hayeswang@...ltek.com>
> ---
>  drivers/net/usb/r8152.c | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c
> index e1466b4..27b0b44 100644
> --- a/drivers/net/usb/r8152.c
> +++ b/drivers/net/usb/r8152.c
> @@ -3585,10 +3585,13 @@ static int rtl8152_rumtime_suspend(struct r8152 *tp)
>  	struct net_device *netdev = tp->netdev;
>  	int ret = 0;
>  
> +	set_bit(SELECTIVE_SUSPEND, &tp->flags);
> +
>  	if (netif_running(netdev) && test_bit(WORK_ENABLE, &tp->flags)) {
>  		u32 rcr = 0;
>  
>  		if (delay_autosuspend(tp)) {
> +			clear_bit(SELECTIVE_SUSPEND, &tp->flags);
>  			ret = -EBUSY;
>  			goto out1;
>  		}
> @@ -3605,6 +3608,7 @@ static int rtl8152_rumtime_suspend(struct r8152 *tp)
>  			if (!(ocp_data & RXFIFO_EMPTY)) {
>  				rxdy_gated_en(tp, false);
>  				ocp_write_dword(tp, MCU_TYPE_PLA, PLA_RCR, rcr);
> +				clear_bit(SELECTIVE_SUSPEND, &tp->flags);
>  				ret = -EBUSY;

If you are going to start using bit operations then you may need smp_mb_before/after_atomic.