netdev - Re: [PATCH iproute2 v5 2/4] ifstat: Add extended statistics to ifstat

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170129203425.070a27d6@xeon-e3>
Date:   Sun, 29 Jan 2017 20:34:25 -0800
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Nogah Frankel <nogahf@...lanox.com>
Cc:     netdev@...r.kernel.org, roopa@...ulusnetworks.com,
        roszenrami@...il.com, jbenc@...hat.com,
        sergei.shtylyov@...entembedded.com, jiri@...lanox.com,
        eladr@...lanox.com, idosch@...lanox.com, yotamg@...lanox.com,
        ogerlitz@...lanox.com
Subject: Re: [PATCH iproute2 v5 2/4] ifstat: Add extended statistics to
 ifstat

On Thu, 26 Jan 2017 14:44:39 +0200
Nogah Frankel <nogahf@...lanox.com> wrote:

> Extended stats are part of the RTM_GETSTATS method. This patch adds them
> to ifstat.
> While extended stats can come in many forms, we support only the
> rtnl_link_stats64 struct for them (which is the 64 bits version of struct
> rtnl_link_stats).
> We support stats in the main nesting level, or one lower.
> The extension can be called by its name or any shorten of it. If there is
> more than one matched, the first one will be picked.
> 
> To get the extended stats the flag -x <stats type> is used.

It would be better if this command used 64 bit statistics transparently
like other tools in iproute2. Transparency is always better user experience.