netdev - Re: [PATCH net v2] net/sched: matchall: Fix configuration race

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170201.115828.2242919958813726618.davem@davemloft.net>
Date:   Wed, 01 Feb 2017 11:58:28 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     yotamg@...lanox.com
Cc:     jiri@...lanox.com, idosch@...lanox.com, eladr@...lanox.com,
        daniel@...earbox.net, jhs@...atatu.com, netdev@...r.kernel.org
Subject: Re: [PATCH net v2] net/sched: matchall: Fix configuration race

From: Yotam Gigi <yotamg@...lanox.com>
Date: Tue, 31 Jan 2017 15:14:29 +0200

> In the current version, the matchall internal state is split into two
> structs: cls_matchall_head and cls_matchall_filter. This makes little
> sense, as matchall instance supports only one filter, and there is no
> situation where one exists and the other does not. In addition, that led
> to some races when filter was deleted while packet was processed.
> 
> Unify that two structs into one, thus simplifying the process of matchall
> creation and deletion. As a result, the new, delete and get callbacks have
> a dummy implementation where all the work is done in destroy and change
> callbacks, as was done in cls_cgroup.
> 
> Fixes: bf3994d2ed31 ("net/sched: introduce Match-all classifier")
> Reported-by: Daniel Borkmann <daniel@...earbox.net>
> Signed-off-by: Yotam Gigi <yotamg@...lanox.com>
> Acked-by: Jiri Pirko <jiri@...lanox.com>

Applied and queued up for -stable, thanks.