netdev - Re: [PATCH net-next] net: reduce skb_warn_bad

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170201.120306.1841734939749372887.davem@davemloft.net>
Date:   Wed, 01 Feb 2017 12:03:06 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     eric.dumazet@...il.com
Cc:     netdev@...r.kernel.org, dvyukov@...gle.com, willemb@...gle.com
Subject: Re: [PATCH net-next] net: reduce skb_warn_bad_offload() noise

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Tue, 31 Jan 2017 10:20:32 -0800

> From: Eric Dumazet <edumazet@...gle.com>
> 
> Dmitry reported warnings occurring in __skb_gso_segment() [1]
> 
> All SKB_GSO_DODGY producers can allow user space to feed
> packets that trigger the current check.
> 
> We could prevent them from doing so, rejecting packets, but
> this might add regressions to existing programs.
> 
> It turns out our SKB_GSO_DODGY handlers properly set up checksum
> information that is needed anyway when packets needs to be segmented.
> 
> By checking again skb_needs_check() after skb_mac_gso_segment(),
> we should remove these pesky warnings, at a very minor cost.
> 
> With help from Willem de Bruijn
 ...
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Reported-by: Dmitry Vyukov  <dvyukov@...gle.com>
> Cc: Willem de Bruijn <willemb@...gle.com>

Applied, thanks Eric.