netdev - Re: [PATCH net-next] unix: add ioctl to open a unix socket file with O

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170202.215825.2190640542795320839.davem@davemloft.net>
Date:   Thu, 02 Feb 2017 21:58:25 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     avagin@...nvz.org
Cc:     netdev@...r.kernel.org, criu@...nvz.org
Subject: Re: [PATCH net-next] unix: add ioctl to open a unix socket file
 with O_PATH

From: Andrei Vagin <avagin@...nvz.org>
Date: Wed,  1 Feb 2017 11:00:45 -0800

> This ioctl opens a file to which a socket is bound and
> returns a file descriptor. The caller has to have CAP_NET_ADMIN
> in the socket network namespace.
> 
> Currently it is impossible to get a path and a mount point
> for a socket file. socket_diag reports address, device ID and inode
> number for unix sockets. An address can contain a relative path or
> a file may be moved somewhere. And these properties say nothing about
> a mount namespace and a mount point of a socket file.
> 
> With the introduced ioctl, we can get a path by reading
> /proc/self/fd/X and get mnt_id from /proc/self/fdinfo/X.
> 
> In CRIU we are going to use this ioctl to dump and restore unix socket.
> 
> Here is an example how it can be used:
 ...
> Signed-off-by: Andrei Vagin <avagin@...nvz.org>

This looks fine to me, applied, thanks.