netdev - Re: [PATCH] net-next: treewide use is_vlan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1486185045.22276.79.camel@perches.com>
Date:   Fri, 03 Feb 2017 21:10:45 -0800
From:   Joe Perches <joe@...ches.com>
To:     Parav Pandit <parav@...lanox.com>, dledford@...hat.com,
        sean.hefty@...el.com, hal.rosenstock@...il.com, monis@...lanox.com,
        santosh@...lsio.com, ganeshgr@...lsio.com,
        manish.chopra@...ium.com, rahul.verma@...ium.com,
        Dept-GELinuxNICDev@...ium.com, harish.patil@...ium.com,
        kys@...rosoft.com, haiyangz@...rosoft.com, sthemmin@...rosoft.com,
        QLogic-Storage-Upstream@...gic.com, jejb@...ux.vnet.ibm.com,
        martin.petersen@...cle.com, jth@...nel.org, arvid.brodin@...en.se,
        davem@...emloft.net, leon@...nel.org, sagi@...mberg.me,
        swise@...ngridcomputing.com, bart.vanassche@...disk.com,
        valex@...lanox.com, arnd@...db.de, weiyj.lk@...il.com,
        jmaxwell37@...il.com, varun@...lsio.com, jbenc@...hat.com,
        linux-rdma@...r.kernel.org, netdev@...r.kernel.org,
        devel@...uxdriverproject.org, linux-scsi@...r.kernel.org,
        fcoe-devel@...n-fcoe.org
Subject: Re: [PATCH] net-next: treewide use is_vlan_dev() helper function.

On Fri, 2017-02-03 at 22:26 -0600, Parav Pandit wrote:
> This patch makes use of is_vlan_dev() function instead of flag
> comparison which is exactly done by is_vlan_dev() helper function.

Thanks.

btw:  after applying this patch, there is one left

$ git grep -E -n "&\s*IFF_802_1Q_VLAN\b" -- "*.c"
drivers/net/ethernet/chelsio/cxgb4/l2t.c:435:   if (neigh->dev->priv_flags & IFF_802_1Q_VLAN)