netdev - RE: [PATCH] net-next: treewide use is_vlan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <VI1PR0502MB300889FE34A841AD7C84EAE7D14E0@VI1PR0502MB3008.eurprd05.prod.outlook.com>
Date:   Sat, 4 Feb 2017 16:47:14 +0000
From:   Parav Pandit <parav@...lanox.com>
To:     Joe Perches <joe@...ches.com>,
        "dledford@...hat.com" <dledford@...hat.com>,
        "sean.hefty@...el.com" <sean.hefty@...el.com>,
        "hal.rosenstock@...il.com" <hal.rosenstock@...il.com>,
        Moni Shoua <monis@...lanox.com>,
        "santosh@...lsio.com" <santosh@...lsio.com>,
        "ganeshgr@...lsio.com" <ganeshgr@...lsio.com>,
        "manish.chopra@...ium.com" <manish.chopra@...ium.com>,
        "rahul.verma@...ium.com" <rahul.verma@...ium.com>,
        "Dept-GELinuxNICDev@...ium.com" <Dept-GELinuxNICDev@...ium.com>,
        "harish.patil@...ium.com" <harish.patil@...ium.com>,
        kys <kys@...rosoft.com>,
        "haiyangz@...rosoft.com" <haiyangz@...rosoft.com>,
        "sthemmin@...rosoft.com" <sthemmin@...rosoft.com>,
        "QLogic-Storage-Upstream@...gic.com" 
        <QLogic-Storage-Upstream@...gic.com>,
        "jejb@...ux.vnet.ibm.com" <jejb@...ux.vnet.ibm.com>,
        "martin.petersen@...cle.com" <martin.petersen@...cle.com>,
        "jth@...nel.org" <jth@...nel.org>,
        "arvid.brodin@...en.se" <arvid.brodin@...en.se>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "leon@...nel.org" <leon@...nel.org>,
        "sagi@...mberg.me" <sagi@...mberg.me>,
        "swise@...ngridcomputing.com" <swise@...ngridcomputing.com>,
        "bart.vanassche@...disk.com" <bart.vanassche@...disk.com>,
        Alex Vesker <valex@...lanox.com>,
        "arnd@...db.de" <arnd@...db.de>,
        "weiyj.lk@...il.com" <weiyj.lk@...il.com>,
        "jmaxwell37@...il.com" <jmaxwell37@...il.com>,
        "varun@...lsio.com" <varun@...lsio.com>,
        "jbenc@...hat.com" <jbenc@...hat.com>,
        "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "devel@...uxdriverproject.org" <devel@...uxdriverproject.org>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "fcoe-devel@...n-fcoe.org" <fcoe-devel@...n-fcoe.org>
Subject: RE: [PATCH] net-next: treewide use is_vlan_dev() helper function.

Hi Joe,

> -----Original Message-----
> From: Joe Perches [mailto:joe@...ches.com]
> On Fri, 2017-02-03 at 22:26 -0600, Parav Pandit wrote:
> > This patch makes use of is_vlan_dev() function instead of flag
> > comparison which is exactly done by is_vlan_dev() helper function.
> 
> Thanks.
> 
> btw:  after applying this patch, there is one left
>
I am sending v1 to cover it as well.

> $ git grep -E -n "&\s*IFF_802_1Q_VLAN\b" -- "*.c"
> drivers/net/ethernet/chelsio/cxgb4/l2t.c:435:   if (neigh->dev->priv_flags &
> IFF_802_1Q_VLAN)