netdev - Re: [PATCH] [net-next] net: qcom/emac: add ethool support for setting pause parameters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170207.131935.63339253886860831.davem@davemloft.net>
Date:   Tue, 07 Feb 2017 13:19:35 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     timur@...eaurora.org
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH] [net-next] net: qcom/emac: add ethool support for
 setting pause parameters

From: Timur Tabi <timur@...eaurora.org>
Date: Mon,  6 Feb 2017 15:34:52 -0600

> To support setting the pause parameters, the driver can no longer just
> mirror the PHY.  The set_pauseparam feature allows the driver to
> force the setting in the MAC, regardless of how the PHY is configured.
> This means that we now need to maintain an internal state for pause
> frame support, and so get_pauseparam also needs to be updated.
> 
> If the interface is already running when the setting is changed, then
> the interface is reset.
> 
> Note that if the MAC is configured to enable RX pause frame support
> (i.e. it transmits pause frames to throttle the other end), but the
> PHY is configured to block those frames, then the feature will not work.
> 
> Also some buffer size initialization code into emac_init_adapter(),
> so that it lives with similar code, including the initializtion of
> pause frame support.
> 
> Signed-off-by: Timur Tabi <timur@...eaurora.org>

Looks good, applied, thanks Timur.