netdev - Re: [PATCHv4 0/7] Refactor macvtap to re-use tap functionality by other virtual intefaces

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170207.132822.668043461053676694.davem@davemloft.net>
Date:   Tue, 07 Feb 2017 13:28:22 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     sainath.grandhi@...el.com
Cc:     netdev@...r.kernel.org, mahesh@...dewar.net,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCHv4 0/7] Refactor macvtap to re-use tap functionality by
 other virtual intefaces

From: Sainath Grandhi <sainath.grandhi@...el.com>
Date: Mon,  6 Feb 2017 13:36:08 -0800

> Tap character devices can be implemented on other virtual interfaces like
> ipvlan, similar to macvtap. Source code for tap functionality in macvtap
> can be re-used for this purpose.
> 
> This patch series splits macvtap source into two modules, macvtap and tap.
> This patch series also includes a patch for implementing tap character
> device driver based on the IP-VLAN network interface, called ipvtap.
> 
> These patches are tested on x86 platform.

You're going to have to rework the module and Kconfig parts of this set
of changes.

The user should not have to modify any existing Kconfig setting to get
the same set of modules which already exist today.

Yet when I run "make oldconfig" after applying these changes it prompts
me for:

    TAP module support for virtual interfaces (TAP) [N/m/y/?] (NEW) 

And that's not really acceptable.  I had MACVTAP set, I should still get
the infrastructure necessary to get that module built.

If you want to do patch #6 you have to do it in a way that is transparent
to existing kernel configs.

Thanks.