netdev - Re: [PATCH iproute2] ip route: Make name of protocol 0 consistent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5d4b2d3f-300d-2486-c660-b4704c41cacd@cumulusnetworks.com>
Date:   Tue, 7 Feb 2017 14:51:45 -0700
From:   David Ahern <dsa@...ulusnetworks.com>
To:     Stephen Hemminger <stephen@...workplumber.org>
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH iproute2] ip route: Make name of protocol 0 consistent

On 2/7/17 2:40 PM, Stephen Hemminger wrote:
>> Reading the file changes the string in rtnl_rtprot_tab for
>> RTPROT_UNSPEC. Both string values -- "none" and "unspec" come from
>> iproute2, so my point is that string is inconsistent within iproute2.
> 
> Why not change the value in the table rtnl_rtprot_tab to be unspec this would
> make the command consistent with the value in the header file.
> 

I flipped a coin; it landed on config file.

"none" is the value that has shown up for 13+ years unless a custom
protocol value is used triggering the 'unspec'. Seems to me a custom
protocol value is a rare event suggesting conformity to "none" over
"unspsec". I really don't care what the string is, but it should be
consistent. If you want 'unspec' I'll change rtnl_rtprot_tab