netdev - Re: [RFC v3 09/11] IB/hfi1: HFI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170208182125.GA77708@knc-06.sc.intel.com>
Date:   Wed, 8 Feb 2017 10:21:25 -0800
From:   "Vishwanathapura, Niranjana" <niranjana.vishwanathapura@...el.com>
To:     Parav Pandit <parav@...lanox.com>
Cc:     "dledford@...hat.com" <dledford@...hat.com>,
        "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "dennis.dalessandro@...el.com" <dennis.dalessandro@...el.com>,
        "ira.weiny@...el.com" <ira.weiny@...el.com>,
        Andrzej Kacprowski <andrzej.kacprowski@...el.com>
Subject: Re: [RFC v3 09/11] IB/hfi1: HFI_VNIC RDMA netdev support

On Wed, Feb 08, 2017 at 04:06:40AM +0000, Parav Pandit wrote:
>Hi,
>
>> -----Original Message-----
>> From: linux-rdma-owner@...r.kernel.org [mailto:linux-rdma-
>> owner@...r.kernel.org] On Behalf Of Vishwanathapura, Niranjana
>> Sent: Tuesday, February 7, 2017 2:23 PM
>> To: dledford@...hat.com
>> Cc: linux-rdma@...r.kernel.org; netdev@...r.kernel.org;
>> dennis.dalessandro@...el.com; ira.weiny@...el.com; Niranjana
>> Vishwanathapura <niranjana.vishwanathapura@...el.com>; Andrzej
>> Kacprowski <andrzej.kacprowski@...el.com>
>> Subject: [RFC v3 09/11] IB/hfi1: HFI_VNIC RDMA netdev support
>>
>> Add support to create and free HFI_VNIC rdma netdev devices.
>> Implement netstack interface functionality including xmit_skb, receive side
>> NAPI etc. Also implement rdma netdev control functions.
>>
>
>All code in this particular patch belong to netdev VNIC ULP driver.
>There is nothing much that appears specific to IB/RDMA that makes drivers/infiniband/hw as better place to be.
>It has netdev tx, rx, napi, stats in this patch.
>If VNIC is a ULP than most of the VNIC specific code should reside in the ULP directory or drivers/net/ethernet ?

This patch implements HW specific portion of VNIC netdev. As it turnes out HW 
queue spefific netstack interfacing (like NAPI, xmit_skb, Tx queue throttling 
etc) are specific to HW implementation of the queues. Netstack APIs are 
designed for that. Hence they belong in HW driver here and not in ULP.

The HFI_VNIC ULP, implements control plane operatings by tapping into control 
operations (open, close etc and encapsulation as specified by control plane).

Niranjana