netdev - Re: [PATCH 0/3] rhashtable: Handle table allocation failure during insertion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170208.132642.68242478649592606.davem@davemloft.net>
Date:   Wed, 08 Feb 2017 13:26:42 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     herbert@...dor.apana.org.au
Cc:     tgraf@...g.ch, netdev@...r.kernel.org
Subject: Re: [PATCH 0/3] rhashtable: Handle table allocation failure during
 insertion

From: Herbert Xu <herbert@...dor.apana.org.au>
Date: Tue, 7 Feb 2017 20:38:27 +0800

> This series tackles the problem of table allocation failures during
> insertion.  The issue is that we cannot vmalloc during insertion.
> This series deals with this by introducing nested tables.
> 
> The first two patches removes manual hash table walks which cannot
> work on a nested table.
> 
> The final patch introduces nested tables.
> 
> I've tested this with test_rhashtable and it appears to work.

rhashtable is indeed getting quite complex, but I understand your
motivation for doing this work.

I also agree that only true OOM situations should cause insertion
failures.

Given the delicate nature of change rhashtable this way, I'm going
to let these changes sit for a couple days before applying them.

Thanks Herbert.