netdev - Re: [patch net-next] net: dsa: bcm_sf2: cleanup bcm_sf2_cfp_rule

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170208.132724.942207581380658378.davem@davemloft.net>
Date:   Wed, 08 Feb 2017 13:27:24 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     dan.carpenter@...cle.com
Cc:     andrew@...n.ch, f.fainelli@...il.com,
        vivien.didelot@...oirfairelinux.com, netdev@...r.kernel.org,
        kernel-janitors@...r.kernel.org
Subject: Re: [patch net-next] net: dsa: bcm_sf2: cleanup
 bcm_sf2_cfp_rule_get() a little

From: Dan Carpenter <dan.carpenter@...cle.com>
Date: Tue, 7 Feb 2017 16:15:27 +0300

> This patch doesn't affect how the code works.
> 
> My static checker complains that the mask and shift doesn't make sense
> because 0xffffff << 16 goes beyond the end of 32 bits.  It should be
> 0xffff instead but the existing code won't cause runtime bugs.
> 
> Also the casting here is not needed and not consistent with the rest of
> the code.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>

Applied, thanks Dan.