netdev - Re: [PATCH net-next] net: ethtool: add support for forward error correction modes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACd6PL3JBs-i-0m5Bx_A0-4DK+ig3sVQsVVP_4hYLo4xwhEE6g@mail.gmail.com>
Date:   Sat, 11 Feb 2017 10:53:39 -0800
From:   Vidya Chowdary <vidya.chowdary@...il.com>
To:     "Mintz, Yuval" <Yuval.Mintz@...ium.com>
Cc:     Vidya Sagar Ravipati <vidya@...ulusnetworks.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "leedom@...lsio.com" <leedom@...lsio.com>,
        "linville@...driver.com" <linville@...driver.com>,
        "jeffrey.t.kirsher@...el.com" <jeffrey.t.kirsher@...el.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "roopa@...ulusnetworks.com" <roopa@...ulusnetworks.com>,
        "dustin@...ulusnetworks.com" <dustin@...ulusnetworks.com>,
        "odedw@...lanox.com" <odedw@...lanox.com>,
        "ariela@...lanox.com" <ariela@...lanox.com>,
        "galp@...lanox.com" <galp@...lanox.com>
Subject: Re: [PATCH net-next] net: ethtool: add support for forward error
 correction modes

On Sat, Feb 11, 2017 at 5:33 AM, Mintz, Yuval <Yuval.Mintz@...ium.com> wrote:
>> +/**
>> + * struct ethtool_fecparam - Ethernet forward error correction(fec)
>> +parameters
>> + * @cmd: Command number = %ETHTOOL_GFECPARAM or
>> %ETHTOOL_SFECPARAM
>> + * @active_fec: FEC mode which is active on porte
>> + * @fec: Bitmask of supported/configured FEC modes
>> + * @rsvd: Reserved for future extensions. i.e FEC bypass feature.
>> + *
>> + * Drivers should reject a non-zero setting of @autoneg when
>> + * autoneogotiation is disabled (or not supported) for the link.
>> + *
>> + */
>
> Why request this from drivers?
> Can't you reject such configuration requests in the ethtool-core?
Missed to remove this comment as FEC configuration is completely
decoupled from auto negotiation
and setting of auto negotiation is not required along with FEC
paramters anymore.
Thanks for catching it and will remove the comment in v2 patch if
there are any comments