netdev - RE: [PATCH net-next] net: ethtool: add support for forward error correction modes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BL2PR07MB2306B8E60E4862D7939586378D470@BL2PR07MB2306.namprd07.prod.outlook.com>
Date:   Sat, 11 Feb 2017 13:33:31 +0000
From:   "Mintz, Yuval" <Yuval.Mintz@...ium.com>
To:     Vidya Sagar Ravipati <vidya@...ulusnetworks.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "leedom@...lsio.com" <leedom@...lsio.com>,
        "linville@...driver.com" <linville@...driver.com>,
        "jeffrey.t.kirsher@...el.com" <jeffrey.t.kirsher@...el.com>,
        "davem@...emloft.net" <davem@...emloft.net>
CC:     "roopa@...ulusnetworks.com" <roopa@...ulusnetworks.com>,
        "dustin@...ulusnetworks.com" <dustin@...ulusnetworks.com>,
        "odedw@...lanox.com" <odedw@...lanox.com>,
        "ariela@...lanox.com" <ariela@...lanox.com>,
        "galp@...lanox.com" <galp@...lanox.com>,
        "vidya.chowdary@...il.com" <vidya.chowdary@...il.com>
Subject: RE: [PATCH net-next] net: ethtool: add support for forward error
 correction modes

> +/**
> + * struct ethtool_fecparam - Ethernet forward error correction(fec)
> +parameters
> + * @cmd: Command number = %ETHTOOL_GFECPARAM or
> %ETHTOOL_SFECPARAM
> + * @active_fec: FEC mode which is active on porte
> + * @fec: Bitmask of supported/configured FEC modes
> + * @rsvd: Reserved for future extensions. i.e FEC bypass feature.
> + *
> + * Drivers should reject a non-zero setting of @autoneg when
> + * autoneogotiation is disabled (or not supported) for the link.
> + *
> + */

Why request this from drivers?
Can't you reject such configuration requests in the ethtool-core?