netdev - Re: [PATCH iproute2 1/1] man page: add page for skbmod action

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170217080049.GA16596@penelope.horms.nl>
Date:   Fri, 17 Feb 2017 09:00:51 +0100
From:   Simon Horman <simon.horman@...ronome.com>
To:     Lucas Bates <lucasb@...atatu.com>
Cc:     stephen@...workplumber.org, jhs@...atatu.com, mrv@...atatu.com,
        netdev@...r.kernel.org
Subject: Re: [PATCH iproute2 1/1] man page: add page for skbmod action

On Fri, Feb 10, 2017 at 06:28:54PM -0500, Lucas Bates wrote:
> Signed-off-by: Lucas Bates <lucasb@...atatu.com>
> Signed-off-by: Jamal Hadi Salim <jhs@...atatu.com>
> Signed-off-by: Roman Mashak <mrv@...atatu.com>
> ---
>  man/man8/Makefile    |   2 +-
>  man/man8/tc-skbmod.8 | 137 +++++++++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 138 insertions(+), 1 deletion(-)
>  create mode 100644 man/man8/tc-skbmod.8
> 
> diff --git a/man/man8/Makefile b/man/man8/Makefile
> index bc2fc81..1bd2f02 100644
> --- a/man/man8/Makefile
> +++ b/man/man8/Makefile
> @@ -16,7 +16,7 @@ MAN8PAGES = $(TARGETS) ip.8 arpd.8 lnstat.8 routel.8 rtacct.8 rtmon.8 rtpr.8 ss.
>  	tc-basic.8 tc-cgroup.8 tc-flow.8 tc-flower.8 tc-fw.8 tc-route.8 \
>  	tc-tcindex.8 tc-u32.8 tc-matchall.8 \
>  	tc-connmark.8 tc-csum.8 tc-mirred.8 tc-nat.8 tc-pedit.8 tc-police.8 \
> -	tc-simple.8 tc-skbedit.8 tc-vlan.8 tc-xt.8  tc-ife.8 \
> +	tc-simple.8 tc-skbedit.8 tc-vlan.8 tc-xt.8 tc-skbmod.8 tc-ife.8 \
>  	tc-tunnel_key.8 \
>  	devlink.8 devlink-dev.8 devlink-monitor.8 devlink-port.8 devlink-sb.8 \
>  	ifstat.8

FWIW the above does not seem to apply cleanly against the net-next branch.

The above not withstanding I am very pleased to see this documentation
and in particular the presence of examples in it.

Reviewed-by: Simon Horman <simon.horman@...ronome.com>


Do you know if there are any plans to extend the number of fields supported
by skmod? I think it would be useful to use it to allow matches to be
robust in the presence of variable length options: e.g. to modify L4 ports
fields in the presence (or absence) of IP options.