netdev - Re: [PATCH 1/2] tcp: setup random timestamp offset when write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 20 Feb 2017 19:29:26 +0300
From:   Alexey Kodanev <alexey.kodanev@...cle.com>
To:     David Miller <davem@...emloft.net>
Cc:     netdev@...r.kernel.org, fw@...len.de, edumazet@...gle.com
Subject: Re: [PATCH 1/2] tcp: setup random timestamp offset when write_seq
 already set

On 20.02.2017 18:18, David Miller wrote:
> This would be so much easier to understand if it were coded as:
> 	if (!tp->repair) {
> 		seq = secure_tcp_sequence_number(...);
> 		if (!tp->write_seq)
> 			tp->write_seq = seq;
> 	}

Hi David,

Thought about not adding extra variable here...
Agree,it looks much better and easier to follow.

Should I send a patch with this version modified as you
suggested or we can inherit ts offsetfrom tcptw->tw_ts_offset
in tcp_twsk_unique()?

Thanks,
Alexey