netdev - Re: [RESEND PATCH 1/1] can: m_can: fix bitrate setup on latest silicon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170220163714.uj5el22c5tq47cul@piout.net>
Date:   Mon, 20 Feb 2017 17:37:14 +0100
From:   Alexandre Belloni <alexandre.belloni@...e-electrons.com>
To:     Oliver Hartkopp <socketcan@...tkopp.net>
Cc:     Quentin Schulz <quentin.schulz@...e-electrons.com>,
        fvallee@...rea.fr, wg@...ndegger.com, mkl@...gutronix.de,
        linux-can@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, boris.brezillon@...e-electrons.com,
        nicolas.ferre@...el.com
Subject: Re: [RESEND PATCH 1/1] can: m_can: fix bitrate setup on latest
 silicon

On 19/02/2017 at 16:37:50 +0100, Oliver Hartkopp wrote:
> Fortunately I was contacted by Bosch this Friday as they want to contribute
> a driver upgrade to support IP cores up to 3.2.x.
> Additionally their plan is to use Device Tree information to determine the
> IP core revision - or at least to cross check its information with the
> register information used in your suggestion.

My opinion is that is is not really useful. Either we use the version
info from the register or DT. But that is probably a matter of taste and
you are the maintainer :)

> For that reason I would suggest to wait for the driver updates from Bosch
> instead of adding an incomplete fix for only one change of eleven.
> 

Well, having something working right now is still better that nothing. I
think it is worth having that patch now so CAN is working on our
platforms.

Everything else can probably be built on top of it anyway.

-- 
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com