netdev - Re: [RESEND PATCH 1/1] can: m_can: fix bitrate setup on latest silicon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <eb9c2ef8-abea-9a93-bfa3-9c3bc849a022@pengutronix.de>
Date:   Mon, 20 Feb 2017 17:44:39 +0100
From:   Marc Kleine-Budde <mkl@...gutronix.de>
To:     Alexandre Belloni <alexandre.belloni@...e-electrons.com>,
        Oliver Hartkopp <socketcan@...tkopp.net>
Cc:     Quentin Schulz <quentin.schulz@...e-electrons.com>,
        fvallee@...rea.fr, wg@...ndegger.com, linux-can@...r.kernel.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        boris.brezillon@...e-electrons.com, nicolas.ferre@...el.com
Subject: Re: [RESEND PATCH 1/1] can: m_can: fix bitrate setup on latest
 silicon

On 02/20/2017 05:37 PM, Alexandre Belloni wrote:
> On 19/02/2017 at 16:37:50 +0100, Oliver Hartkopp wrote:
>> Fortunately I was contacted by Bosch this Friday as they want to contribute
>> a driver upgrade to support IP cores up to 3.2.x.
>> Additionally their plan is to use Device Tree information to determine the
>> IP core revision - or at least to cross check its information with the
>> register information used in your suggestion.
> 
> My opinion is that is is not really useful. Either we use the version
> info from the register or DT. But that is probably a matter of taste and
> you are the maintainer :)

I see no benefit of holding the version number in the DT, as long as the
version of the HW can be auto discovered properly.

>> For that reason I would suggest to wait for the driver updates from Bosch
>> instead of adding an incomplete fix for only one change of eleven.

> Well, having something working right now is still better that nothing. I
> think it is worth having that patch now so CAN is working on our
> platforms.
> 
> Everything else can probably be built on top of it anyway.

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |



Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)